On date Monday 2023-12-11 02:35:04 +0100, Clément Bœsch wrote: > This is already assigned at declaration. > --- > libavcodec/proresenc_kostya.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c > index 7aed3974c3..6e1d5a0cef 100644 > --- a/libavcodec/proresenc_kostya.c > +++ b/libavcodec/proresenc_kostya.c > @@ -440,7 +440,6 @@ static void encode_dcs(PutBitContext *pb, int16_t *blocks, > prev_dc = (blocks[0] - 0x4000) / scale; > encode_vlc_codeword(pb, FIRST_DC_CB, MAKE_CODE(prev_dc)); > sign = 0; > - codebook = 3; > blocks += 64; > > for (i = 1; i < blocks_per_slice; i++, blocks += 64) { > @@ -676,7 +675,6 @@ static int estimate_dcs(int *error, int16_t *blocks, int > blocks_per_slice, > prev_dc = (blocks[0] - 0x4000) / scale; > bits = estimate_vlc(FIRST_DC_CB, MAKE_CODE(prev_dc)); > sign = 0; > - codebook = 3; > blocks += 64; > *error += FFABS(blocks[0] - 0x4000) % scale;
Since this is the only value assigned with declaration, maybe it's better to drop the codebook = 3 in the assignment, but LGTM anyway. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".