Quoting James Almer (2023-12-14 21:14:26) > +/** > + * Mix Gain Parameter Data as defined in section 3.8.1 of IAMF. > + */ > +typedef struct AVIAMFMixGain { > + const AVClass *av_class; > + > + /** > + * Duration for the given subblock. It must not be 0.
In what units? Same for all durations in this patch. > +typedef struct AVIAMFParamDefinition { > + const AVClass *av_class; > + > + /** > + * Offset in bytes from the start of this struct, at which the subblocks > + * array is located. > + */ > + size_t subblocks_offset; > + /** > + * Size in bytes of each element in the subblocks array. > + */ > + size_t subblock_size; > + /** > + * Number of subblocks in the array. > + * > + * Must be 0 if @ref constant_subblock_duration is not 0. > + */ > + unsigned int nb_subblocks; > + > + /** > + * Parameters type. Determines the type of the subblock elements. > + */ > + enum AVIAMFParamDefinitionType type; > + > + /** > + * Identifier for the paremeter substream. > + */ > + unsigned int parameter_id; > + /** > + * Sample rate for the paremeter substream. It must not be 0. > + */ > + unsigned int parameter_rate; > + > + /** > + * The duration of the all subblocks in this parameter definition. > + * > + * May be 0, in which case all duration values should be specified in > + * another parameter definition referencing the same parameter_id. > + */ > + unsigned int duration; > + /** > + * The duration of every subblock in the case where all subblocks, with > + * the optional exception of the last subblock, have equal durations. > + * > + * Must be 0 if subblocks have different durations. > + */ > + unsigned int constant_subblock_duration; This also seems like should be a flags field. Otherwise looks good. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".