On 2/5/2024 12:28 PM, Andreas Rheinhardt wrote:
James Almer:
On 2/5/2024 12:12 PM, Andreas Rheinhardt wrote:
James Almer:
On 2/3/2024 11:50 AM, Andreas Rheinhardt wrote:
diff --git a/libavformat/movenc.h b/libavformat/movenc.h
index 60363198c9..fee3e759e0 100644
--- a/libavformat/movenc.h
+++ b/libavformat/movenc.h
@@ -25,7 +25,9 @@
    #define AVFORMAT_MOVENC_H
      #include "avformat.h"
+#include "iamf.h"
    #include "movenccenc.h"
+#include "libavcodec/bsf.h"

There is no need to include these here, as you don't need complete
types. This has the added benefit of forcing you to actually include
the
files where you are using them (namely in movenc.c, where you forgot to
include bsf.h).

Ok, fixed locally.

Will push the set soon.

It seems you have not noticed my objection to the first version of
your set.

- Andreas

Can you link to it?

Sorry, it was v2:
https://ffmpeg.org/pipermail/ffmpeg-devel/2024-February/320722.html

- Andreas

I removed the codec list from the split bsf like you asked, and explained what the bsfs do in the documentation.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to