On date Wednesday 2024-03-27 12:32:11 +0100, Andreas Rheinhardt wrote: > Marth64: > > Recent advice plus my own experience agree that this pattern > > is error-prone. Instead, set `ret` in its own line and do > > the error validation after. Also, explicitly return 0 on success > > in dvdvideo_chapters_setup_preindex() > > > > Signed-off-by: Marth64 <mart...@proxyid.net> > > --- > > libavformat/dvdvideodec.c | 132 +++++++++++++++++++++++++------------- > > 1 file changed, 86 insertions(+), 46 deletions(-) [...] > When I argued against the "if ((ret = ...) < 0)" pattern, I meant single > checks. In chained cases like the above the compactness outweighs the > potential precedence problem.
Holding the patch for now, so it can be reworked to reduce the scope of this change. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
