On Mon, 8 Apr 2024, J. Dekker wrote:
In some cases, these scripts can be called directly by packagers, and
some systems require the interpreter to be explicit.
It is unclear to me which of the changes are needed and for what reason,
please elaborate much more in the commit message.
Is it possible to elaborate on "some systems require the interpreter to be
explicit"? It'd be much nicer to reason about if there was a concrete
example of such a case (even if it certainly is right to add the missing
shebang line).
The changes I see fall into these categories:
- Change "#! <path>" into "#!<path>. Does this change have a functional
effect for someone (where, and why?) or is it purely a cosmetic change?
- Add a shebang line in the generated ffbuild/config.sh. This script is
highly unlikely to be useful to call on its own like that, so while this
probably is good for consistency I don't see it ever making a difference.
- Add a shebang line in ffbuild/libversion.sh. I can see the value in
calling this script directly, outside of our build system. I presume this
is the actual change that makes a difference here?
I don't mind the changes, but I'd prefer to split them into two separate
commits; add missing shebangs (with an example of the case where it really
does make a difference), vs removing extra spaces in shebangs for
consistency (with explicit clarification in the commit message whether
this is only for stylistic consistency or whether it does make a
difference somewhere, and if it does, where).
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
