On Tue, May 21, 2024 at 11:02:09AM +0200, Timo Rothenpieler wrote: > This is based on the preliminary spec for enhanced rtmp v2: > https://veovera.org/docs/enhanced/enhanced-rtmp-v2 > > The spec is not final, and can still undergo breaking changes, hence this set > is purely for comments and review, and not ready to be merged until the final > v2 spec is published. > > There are no samples out in the wild yet, so testing interoperability with > other software has not happened yet either. > Specially the two other multitrack modes, where multiple tracks are in the > same packet, have not been tested at all, since no software can write such > files. > > The set can also be found on GitHub, where ignoring whitespaces makes > specially the last patch a lot more readable: > https://github.com/BtbN/FFmpeg/tree/enhanced-flv >
I ran this against a little review bot I'm working on. Please do s/\* / \*/g on the following: avformat/flvenc: add support for writing multi track audio > +static void flv_write_multichannel_header(AVFormatContext* s, > AVCodecParameters* par, int64_t ts, int stream_index) avformat/flvenc: write enhanced rtmp multichannel info for audio with more than two channels > +static void flv_write_multichannel_body(AVFormatContext* s, > AVCodecParameters* par) > +static int flv_get_multichannel_body_size(AVCodecParameters* par) > +static void flv_write_multichannel_header(AVFormatContext* s, > AVCodecParameters* par, int64_t ts) avformat/flvenc: add enhanced audio codecs > +static void flv_write_aac_header(AVFormatContext* s, AVCodecParameters* par) avformat/flvenc: Implement support for multi-track video > +static void flv_write_codec_header(AVFormatContext* s, AVCodecParameters* > par, int64_t ts, int stream_index) { _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".