On Wed, Jul 17, 2024 at 08:42:41AM +0200, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2024-07-15 16:48:25)
[...]
> > @@ -3155,8 +3156,11 @@ static int decode_slice(HEVCContext *s, const
> > H2645NAL *nal, GetBitContext *gb)
> > int ret;
> >
> > ret = hls_slice_header(&s->sh, s, gb);
> > - if (ret < 0)
> > + if (ret < 0) {
> > + //The code is not capable to rewind from an error, the state now
> > is inconsistant so we cannot use it on depandant slices
>
> ^ ^
>
> e e
> Also I'd drop everything before the comma, why mention rewinding that is
> not implemented and may not be a good idea anyway.It seems we disagree on some things. A failing function should not corrupt the state. We also dont do that in other cases like SPS/PPS. This is also unexpected, so it should be documented. thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Modern terrorism, a quick summary: Need oil, start war with country that has oil, kill hundread thousand in war. Let country fall into chaos, be surprised about raise of fundamantalists. Drop more bombs, kill more people, be surprised about them taking revenge and drop even more bombs and strip your own citizens of their rights and freedoms. to be continued
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
