On Mon, Sep 9, 2024 at 1:01 PM Martin Storsjö <mar...@martin.st> wrote: > On Mon, 9 Sep 2024, Brad Smith wrote: > > > aarch64: Implement support for elf_aux_info(3) on FreeBSD and OpenBSD > > > > FreeBSD 12.0+, OpenBSD -current and what will be OpenBSD 7.6 support > > elf_aux_info(3). > > > > Signed-off-by: Brad Smith <b...@comstyle.com> > > --- > > configure | 2 ++ > > libavutil/aarch64/cpu.c | 2 +- > > libavutil/cpu.c | 9 ++++++++- > > 3 files changed, 11 insertions(+), 2 deletions(-) > > LGTM, thanks. (I guess the same change as in aarch64/cpu.c also could be > done in other architectures' cpu.c?)
I agree. These are the cases I still see in the codebase: libavutil/mips/cpu.c: libavutil/arm/cpu.c: #if defined __linux__ || defined __ANDROID__ libavutil/loongarch/cpu.c: #if defined __linux__ In general we should avoid using system #ifdefs, relying instead on features that can be properly detected by configure. (This comment in unrelated to the patch) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
