On Tue, 18 Aug 2015 08:27:51 -0400 Ganesh Ajjanagadde <gajja...@mit.edu> wrote:
> On Tue, Aug 18, 2015 at 6:57 AM, Michael Niedermayer > <mich...@niedermayer.cc> wrote: > > On Tue, Aug 18, 2015 at 09:04:41AM +0300, Arttu Ylä-Outinen wrote: > >> Signed-off-by: Arttu Ylä-Outinen <arttu.yla-outi...@tut.fi> > >> --- > >> configure | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/configure b/configure > >> index 55cc7fb..3fa37b7 100755 > >> --- a/configure > >> +++ b/configure > >> @@ -5226,7 +5226,7 @@ enabled libgsm && { for gsm_hdr in > >> "gsm.h" "gsm/gsm.h"; do > >> check_lib "${gsm_hdr}" gsm_create > >> -lgsm && break; > >> done || die "ERROR: libgsm not found"; } > >> enabled libilbc && require libilbc ilbc.h > >> WebRtcIlbcfix_InitDecode -lilbc > >> -enabled libkvazaar && require2 libkvazaar kvazaar.h kvz_api_get > >> -lkvazaar > >> +enabled libkvazaar && require_pkg_config kvazaar kvazaar.h > >> kvz_api_get > >> enabled libmfx && require_pkg_config libmfx "mfx/mfxvideo.h" > >> MFXInit > >> enabled libmodplug && require_pkg_config libmodplug > >> libmodplug/modplug.h ModPlug_Load > >> enabled libmp3lame && require "libmp3lame >= 3.98.3" lame/lame.h > >> lame_set_VBR_quality -lmp3lame > > > > applied > > I am fine with this patch, but as per the discussion on Ticket #4197: > https://trac.ffmpeg.org/ticket/4197#comment:29 > don't we support detection without pkg_config as a fallback? > As you can see from this, I am not in favor of unnecessary > complication of configure, > but there are some developers who have concerns about this. We could avoid drama this time, so just let it rest. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel