On Tue, Aug 25, 2015 at 08:19:59PM -0400, Ganesh Ajjanagadde wrote:
> For consistency, prefix with an opt_?

This name is chosen to be consistent with other show_ functions. opt_*
are exclusively used for setting some options AFAICT.

> Maybe you could check the return value of printf?

Absolutely zero calls to printf in FFmpeg are checked. Even if checking
the result code can be more secure, it is way outside the scope of this
patch.

Timothy
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to