On Fri, Aug 28, 2015 at 08:17:41AM -0700, Philip Langdale wrote: > At least for vdpau, the hwaccel init code tries to check the video > profile and ensure that there is a matching vdpau profile available. > > If it can't find a match, it will fail to initialise. > > In the case of wmv3/vc1, I observed initialisation to fail all the > time. It turns out that this is due to the hwaccel being initialised > very early in the codec init, before the profile has been extracted > and set. > > Conceptually, it's a simple fix to reorder the init code, but it gets > messy really fast because ff_get_format(), which is what implicitly > trigger hwaccel init, is called multiple times through various shared > init calls from h263, etc. It's incredibly hard to prove to my own > satisfaction that it's safe to move the vc1 specific init code > ahead of this generic code, but all the vc1 fate tests pass, and I've > visually inspected a couple of samples and things seem correct. > > Signed-off-by: Philip Langdale <phil...@overt.org> > --- > libavcodec/vc1dec.c | 52 ++++++++++++++++++++++++++++------------------------ > 1 file changed, 28 insertions(+), 24 deletions(-)
LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 1 "Used only once" - "Some unspecified defect prevented a second use" "In good condition" - "Can be repaird by experienced expert" "As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
