Michael Niedermayer <mich...@niedermayer.cc> writes:

> this can be factored like:
>
> like
> +    ret = 0;
>      fail:
> +    for (i = 0; i < s->nb_streams; i++)
> +        if (contexts[i])
> +            av_free(contexts[i]->url);
>     av_free(contexts);
> +   if (ret < 0)
>         sap_write_close(s);
>

Yeah this looks much better. I will use it in my v2 patch.

One more question, would it be ok to rename fail label to end label.
I'm not sure if it's worth the change, though.

Thanks,
Lidong
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to