> On Jun 21, 2025, at 12:58, Zhao Zhili <quinkblack-at-foxmail....@ffmpeg.org>
> wrote:
>
>
>
>> On Jun 21, 2025, at 10:15, Jack Lau <jacklau1222gm-at-gmail....@ffmpeg.org>
>> wrote:
>>
>>
>>
>>> On Jun 13, 2025, at 16:56, Jack Lau via ffmpeg-devel
>>> <ffmpeg-devel@ffmpeg.org> wrote:
>>>
>>>
>>> From: Jack Lau <jacklau1...@qq.com>
>>> Subject: [PATCH v3 1/3] avformat/whip: replace AV_OPT_FLAG_DECODING_PARAM
>>> to ENCODING
>>> Date: June 13, 2025 at 16:56:03 GMT+8
>>> To: ffmpeg-devel@ffmpeg.org
>>> Cc: Jack Lau <jacklau1...@qq.com>
>>>
>>>
>>> Signed-off-by: Jack Lau <jacklau1...@qq.com>
>>> ---
>>> libavformat/whip.c | 12 ++++++------
>>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/libavformat/whip.c b/libavformat/whip.c
>>> index 710f24fc5a..a6827d3478 100644
>>> --- a/libavformat/whip.c
>>> +++ b/libavformat/whip.c
>>> @@ -1885,13 +1885,13 @@ static int whip_check_bitstream(AVFormatContext *s,
>>> AVStream *st, const AVPacket
>>> }
>>>
>>> #define OFFSET(x) offsetof(WHIPContext, x)
>>> -#define DEC AV_OPT_FLAG_DECODING_PARAM
>>> +#define ENC AV_OPT_FLAG_ENCODING_PARAM
>>> static const AVOption options[] = {
>>> - { "handshake_timeout", "Timeout in milliseconds for ICE and DTLS
>>> handshake.", OFFSET(handshake_timeout), AV_OPT_TYPE_INT, { .i64 =
>>> 5000 }, -1, INT_MAX, DEC },
>>> - { "pkt_size", "The maximum size, in bytes, of RTP packets
>>> that send out", OFFSET(pkt_size), AV_OPT_TYPE_INT, { .i64 =
>>> 1200 }, -1, INT_MAX, DEC },
>>> - { "authorization", "The optional Bearer token for WHIP
>>> Authorization", OFFSET(authorization), AV_OPT_TYPE_STRING, {
>>> .str = NULL }, 0, 0, DEC },
>>> - { "cert_file", "The optional certificate file path for DTLS",
>>> OFFSET(cert_file), AV_OPT_TYPE_STRING, { .str = NULL
>>> }, 0, 0, DEC },
>>> - { "key_file", "The optional private key file path for DTLS",
>>> OFFSET(key_file), AV_OPT_TYPE_STRING, { .str = NULL },
>>> 0, 0, DEC },
>>> + { "handshake_timeout", "Timeout in milliseconds for ICE and DTLS
>>> handshake.", OFFSET(handshake_timeout), AV_OPT_TYPE_INT, { .i64 =
>>> 5000 }, -1, INT_MAX, ENC },
>>> + { "pkt_size", "The maximum size, in bytes, of RTP packets
>>> that send out", OFFSET(pkt_size), AV_OPT_TYPE_INT, { .i64 =
>>> 1200 }, -1, INT_MAX, ENC },
>>> + { "authorization", "The optional Bearer token for WHIP
>>> Authorization", OFFSET(authorization), AV_OPT_TYPE_STRING, {
>>> .str = NULL }, 0, 0, ENC },
>>> + { "cert_file", "The optional certificate file path for DTLS",
>>> OFFSET(cert_file), AV_OPT_TYPE_STRING, { .str = NULL
>>> }, 0, 0, ENC },
>>> + { "key_file", "The optional private key file path for DTLS",
>>> OFFSET(key_file), AV_OPT_TYPE_STRING, { .str = NULL },
>>> 0, 0, ENC },
>>> { NULL },
>>> };
>>>
>>> --
>>> 2.49.0
>>>
>>>
>>>
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel@ffmpeg.org
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe”.
>> PING.
>
> Applied, thanks.
>
>>
>>
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe”.
There’re two other patches in this patchset
https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=14768
, Could you help merge these please?
I want to submit WHIP NACK patch that depends on these patches.
Best regards
Jack
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
