Marvin Scholz (HE12025-06-25): > Instead of the convoluted nested macros, use a convenience > helper function. While this makes the code slightly longer, it > is now much clearer what is happening without running the file > through a preprocessor first.
I do not find the modified code clearer than the original. Quite the opposite in fact; there is no need to “run[] the file through a preprocessor”, the code is clear enough. > Additionally do not mess with the internals of the dictionary, > just to save two string copies. Should be in a separate patch. Regards, -- Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
