On Sun, Jul 13, 2025 at 4:59 AM James Almer <jamr...@gmail.com> wrote: > > On 7/12/2025 9:32 PM, Michael Niedermayer wrote: > > On Fri, Jul 11, 2025 at 04:04:17PM +0000, Timo Rothenpieler wrote: > >> ffmpeg | branch: master | Timo Rothenpieler <t...@rothenpieler.org> | Tue > >> Jun 24 19:30:19 2025 +0200| [90fa9636efff84ec5a4b06815722c08188dca551] | > >> committer: Timo Rothenpieler > >> > >> avformat/tls_schannel: add DTLS support > >> > >>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=90fa9636efff84ec5a4b06815722c08188dca551 > >> --- > >> > >> configure | 6 +- > >> libavformat/tls_schannel.c | 890 > >> +++++++++++++++++++++++++++++++++++++++++---- > >> libavformat/version.h | 2 +- > >> 3 files changed, 833 insertions(+), 65 deletions(-) > > > > breaks on mingw64 > > > > src/libavformat/tls_schannel.c: In function ‘ff_dtls_export_materials’: > > src/libavformat/tls_schannel.c:606:5: error: unknown type name > > ‘SecPkgContext_KeyingMaterialInfo’; did you mean > > ‘SecPkgContext_NegotiationInfo’? > > This type (and probably everything below) is API introduced on Windows > 10, so unless you build targeting _WIN32_WINNT >= 0x0A00, it will not be > defined. > So i guess we should make the tls_schannel.c force that value, like so: > > > diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c > > index 2a01fb387d..a5cc8d3e27 100644 > > --- a/libavformat/tls_openssl.c > > +++ b/libavformat/tls_openssl.c > > @@ -20,6 +20,11 @@ > > * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA > > 02110-1301 USA > > */ > > > > +#if !defined(_WIN32_WINNT) || _WIN32_WINNT < 0x0A00 > > +#undef _WIN32_WINNT > > +#define _WIN32_WINNT 0x0A00 > > +#endif > > +
Does it introduce a runtime dependency on the new OS? If so the user should perhaps get to control that and the new feature perhaps disabled if build for older Windows. Its a rather niche feature afterall. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
