On Wed, Sep 02, 2015 at 05:33:04PM -0700, Ganesh Ajjanagadde wrote: > On Wed, Sep 2, 2015 at 5:17 PM, Michael Niedermayer <michae...@gmx.at> wrote: > > From: Michael Niedermayer <mich...@niedermayer.cc> > > > > This function avoids the undefined corner cases which affects other absolute > > value functions and macros > > LGTM, except for the comment/commit message. This does not avoid all > weird cases, see e.g
> https://stackoverflow.com/questions/202537/c-macro-question-x-vs-x > but only the reasonable ones, roughly speaking where one does not do > arithmetic expression inside the macro. > Somewhere a note should ideally be made regarding this. added > Furthermore, the commit message ideally should say that this a macro, > not a function to guard people against such abuse of it. fixed applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Republics decline into democracies and democracies degenerate into despotisms. -- Aristotle
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel