On 16/07/2025 18:58, Kacper Michajlow wrote:
> On Tue, 15 Jul 2025 at 00:24, Michael Niedermayer
> <mich...@niedermayer.cc> wrote:
>>
>> ---
>> configure | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/configure b/configure
>> index fc082d5467e..e568eed55d3 100755
>> --- a/configure
>> +++ b/configure
>> @@ -4606,8 +4606,8 @@ set >> $logfile
>> test -n "$valgrind" && toolchain="valgrind-memcheck"
>>
>> enabled ossfuzz && ! echo $CFLAGS | grep -q -- "-fsanitize=" && ! echo
>> $CFLAGS | grep -q -- "-fcoverage-mapping" &&{
>> - add_cflags -fsanitize=address,undefined
>> -fsanitize-coverage=trace-pc-guard,trace-cmp -fno-omit-frame-pointer
>> - add_ldflags -fsanitize=address,undefined
>> -fsanitize-coverage=trace-pc-guard,trace-cmp
>> + add_cflags -fsanitize=fuzzer,address,undefined
>> -fsanitize-memory-track-origins -fno-omit-frame-pointer
>> + add_ldflags -fsanitize=address,undefined
>> }
>
> How about we remove this block of code? Or move it to
> --toolchain=clang-fuzz for local build? In oss-fuzz build environment
> (docker) this flags shouldn't be injected (and are not because of grep
> checks) and instead CFLAGS are used for compile flags and
> --libfuzzer for linking.
>
> - Kacper+1 I have a patch locally which does something similar. We could add these flags only to those targets which need to be compiled with libfuzzer, rather than to all CFLAGS. It saves you having to re-configure if you want to compile some fftool, then some fuzzer binary or vice-versa. -- Frank
OpenPGP_0x03A84C6A098F2C6B.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
