Tried applying the diff from patchwork (https://patchwork.ffmpeg.org/project/ffmpeg/patch/pn3p287mb3339e53168f261f6cccf13b79a...@pn3p287mb3339.indp287.prod.outlook.com/raw/), it applies fine on master. The mbox patch (https://patchwork.ffmpeg.org/project/ffmpeg/patch/pn3p287mb3339e53168f261f6cccf13b79a...@pn3p287mb3339.indp287.prod.outlook.com/mbox/) thou fails to apply saying "empty patch". I had to delete lines 1-199 manually and then it applied. Thanks, Logaprakash. ________________________________ From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> on behalf of Michael Niedermayer <mich...@niedermayer.cc> Sent: Friday, July 18, 2025 4:29 PM To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] swscale/aarch64/output: Implement neon assembly for yuv2planeX_10_c_template()
On Tue, Jul 15, 2025 at 05:06:54AM +0000, Logaprakash Ramajayam wrote: > Handled all the comments and attaching the checkasm results. > > Checkasm Benchmark results: > > > yuv2yuvX_10_LE_16_0_512_accurate_c: 7836.9 ( 1.00x) > yuv2yuvX_10_LE_16_0_512_accurate_neon: 840.4 ( 9.33x) > yuv2yuvX_10_LE_16_0_512_approximate_c: 7930.8 ( 1.00x) > yuv2yuvX_10_LE_16_0_512_approximate_neon: 838.5 ( 9.46x) > yuv2yuvX_10_LE_16_16_512_accurate_c: 7594.3 ( 1.00x) > yuv2yuvX_10_LE_16_16_512_accurate_neon: 815.2 ( 9.32x) > yuv2yuvX_10_LE_16_16_512_approximate_c: 7687.0 ( 1.00x) > yuv2yuvX_10_LE_16_16_512_approximate_neon: 811.9 ( 9.47x) > yuv2yuvX_10_LE_16_32_512_accurate_c: 7366.4 ( 1.00x) > yuv2yuvX_10_LE_16_32_512_accurate_neon: 785.8 ( 9.37x) > yuv2yuvX_10_LE_16_32_512_approximate_c: 7426.5 ( 1.00x) > yuv2yuvX_10_LE_16_32_512_approximate_neon: 786.4 ( 9.44x) > yuv2yuvX_10_LE_16_48_512_accurate_c: 7123.1 ( 1.00x) > yuv2yuvX_10_LE_16_48_512_accurate_neon: 761.7 ( 9.35x) > yuv2yuvX_10_LE_16_48_512_approximate_c: 7182.7 ( 1.00x) > yuv2yuvX_10_LE_16_48_512_approximate_neon: 763.0 ( 9.41x) > yuv2yuvX_10_BE_16_0_512_accurate_c: 8092.6 ( 1.00x) > yuv2yuvX_10_BE_16_0_512_accurate_neon: 860.2 ( 9.41x) > yuv2yuvX_10_BE_16_0_512_approximate_c: 8183.5 ( 1.00x) > yuv2yuvX_10_BE_16_0_512_approximate_neon: 861.4 ( 9.50x) > yuv2yuvX_10_BE_16_16_512_accurate_c: 7837.4 ( 1.00x) > yuv2yuvX_10_BE_16_16_512_accurate_neon: 834.0 ( 9.40x) > yuv2yuvX_10_BE_16_16_512_approximate_c: 7927.9 ( 1.00x) > yuv2yuvX_10_BE_16_16_512_approximate_neon: 834.6 ( 9.50x) > yuv2yuvX_10_BE_16_32_512_accurate_c: 7605.1 ( 1.00x) > yuv2yuvX_10_BE_16_32_512_accurate_neon: 807.5 ( 9.42x) > yuv2yuvX_10_BE_16_32_512_approximate_c: 7691.4 ( 1.00x) > yuv2yuvX_10_BE_16_32_512_approximate_neon: 807.3 ( 9.53x) > yuv2yuvX_10_BE_16_48_512_accurate_c: 7344.3 ( 1.00x) > yuv2yuvX_10_BE_16_48_512_accurate_neon: 782.7 ( 9.38x) > yuv2yuvX_10_BE_16_48_512_approximate_c: 7440.1 ( 1.00x) > yuv2yuvX_10_BE_16_48_512_approximate_neon: 781.9 ( 9.51x) > > From 3e14b4c2e763d2d0c8979e3e99578f5492b7130c Mon Sep 17 00:00:00 2001 > From: Logaprakash Ramajayam <logaprakash.ramaja...@multicorewareinc.com> > Date: Tue, 1 Jul 2025 23:48:36 -0700 > Subject: [PATCH v2 1/1] swscale/aarch64/output: Implement neon assembly for > yuv2planeX_10_c_template() > > --- > libswscale/aarch64/output.S | 189 +++++++++++++++++++++++++++++++++++ > libswscale/aarch64/swscale.c | 38 +++++++ > tests/checkasm/sw_scale.c | 170 ++++++++++++++++++++----------- > 3 files changed, 337 insertions(+), 60 deletions(-) Applying: swscale/aarch64/output: Implement neon assembly for yuv2planeX_10_c_template() Using index info to reconstruct a base tree... M tests/checkasm/sw_scale.c error: patch failed: libswscale/aarch64/output.S:20 error: libswscale/aarch64/output.S: patch does not apply error: patch failed: libswscale/aarch64/swscale.c:158 error: libswscale/aarch64/swscale.c: patch does not apply error: patch failed: tests/checkasm/sw_scale.c:52 error: tests/checkasm/sw_scale.c: patch does not apply error: Did you hand edit your patch? It does not apply to blobs recorded in its index. Patch failed at 0001 swscale/aarch64/output: Implement neon assembly for yuv2planeX_10_c_template() [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great genius has ever existed without some touch of madness. -- Aristotle _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
