Jack Lau <jacklau122...@gmail.com> 于2025年7月21日周一 19:31写道：
Hi Jack,
>
> Remove redundant "WHIP: " prefix in log context
> since it already add whip context.
>
> Fix grammers in whip options descriptions
>
> Signed-off-by: Jack Lau <jacklau1...@qq.com>
> ---
> libavformat/whip.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/libavformat/whip.c b/libavformat/whip.c
> index caac8d5680..3ec4c76b5f 100644
> --- a/libavformat/whip.c
> +++ b/libavformat/whip.c
> @@ -1911,11 +1911,11 @@ static int whip_check_bitstream(AVFormatContext *s,
> AVStream *st, const AVPacket
> static const AVOption options[] = {
> { "handshake_timeout", "Timeout in milliseconds for ICE and DTLS
> handshake.", OFFSET(handshake_timeout), AV_OPT_TYPE_INT, { .i64 =
> 5000 }, -1, INT_MAX, ENC },
> { "pkt_size", "The maximum size, in bytes, of RTP packets that
> send out", OFFSET(pkt_size), AV_OPT_TYPE_INT, { .i64 = 1200 },
> -1, INT_MAX, ENC },
> - { "authorization", "The optional Bearer token for WHIP
> Authorization", OFFSET(authorization), AV_OPT_TYPE_STRING, {
> .str = NULL }, 0, 0, ENC },
> - { "cert_file", "The optional certificate file path for DTLS",
> OFFSET(cert_file), AV_OPT_TYPE_STRING, { .str = NULL },
> 0, 0, ENC },
> - { "key_file", "The optional private key file path for DTLS",
> OFFSET(key_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0,
> 0, ENC },
> + { "authorization", "Optional Bearer token for WHIP Authorization",
> OFFSET(authorization), AV_OPT_TYPE_STRING, { .str = NULL },
> 0, 0, ENC },
> + { "cert_file", "Optional certificate file path for DTLS",
> OFFSET(cert_file), AV_OPT_TYPE_STRING, { .str = NULL },
> 0, 0, ENC },
> + { "key_file", "Optional private key file path for DTLS",
> OFFSET(key_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0,
> 0, ENC },
> { "whip_flags", "Set flags affecting WHIP connection behavior",
> OFFSET(flags), AV_OPT_TYPE_FLAGS, { .i64 = 0 },
> 0, UINT_MAX, ENC, .unit = "flags" },
> - { "ignore_ipv6", "(Optional) Ignore any IPv6 ICE candidate",
> 0, AV_OPT_TYPE_CONST, { .i64 =
> WHIP_FLAG_IGNORE_IPV6 }, 0, UINT_MAX, ENC, .unit = "flags" },
> + { "ignore_ipv6", "Ignore any IPv6 ICE candidate",
> 0, AV_OPT_TYPE_CONST, { .i64 = WHIP_FLAG_IGNORE_IPV6 },
> 0, UINT_MAX, ENC, .unit = "flags" },
Can this line modify in the first patch?, i saw you add this option in
the first patch of this patchset.
> { NULL },
> };
>
> --
> 2.49.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Thanks
Steven
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
