> On Jul 22, 2025, at 20:45, zhaozhenghang <15083277...@163.com> wrote:
>
> In my development scenario, CONFIG_H261_DECODER, CONFIG_H263_DECODER, and
> CONFIG_MPEG4_DECODER are set to 0 by default, resulting in a "statement will
> never be executed" warning during compilation. To enhance code robustness,
> this patch fixes the warning.
>
> Signed-off-by: zhaozhenghang <15083277...@163.com>
> ---
> libavformat/mov.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index ccaa988e4b..4a4641d51b 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -5222,6 +5222,7 @@ static int mov_read_trak(MOVContext *c, AVIOContext
> *pb, MOVAtom atom)
> return ret;
> }
>
> +#if CONFIG_H261_DECODER || CONFIG_H263_DECODER || CONFIG_MPEG4_DECODER
> switch (st->codecpar->codec_id) {
> #if CONFIG_H261_DECODER
> case AV_CODEC_ID_H261:
> @@ -5236,7 +5237,7 @@ static int mov_read_trak(MOVContext *c, AVIOContext
> *pb, MOVAtom atom)
> st->codecpar->height= 0;
> break;
> }
> -
> +#endif
I prefer remove the conditional compile inside the switch.
> // If the duration of the mp3 packets is not constant, then they could
> need a parser
> if (st->codecpar->codec_id == AV_CODEC_ID_MP3
> && sc->time_scale == st->codecpar->sample_rate) {
> --
> 2.50.1.windows.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
