PR #20860 opened by mkver URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20860 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20860.patch
Using unsigned for fps more natural since the corresponding AVTimecode field is unsigned and fixes a -Wformat-truncation warning from GCC 16: in case fps were negative, the hours, minutes and seconds would be negative, leading to an additional '-' which is not accounted for in AV_TIMECODE_STR_SIZE. Replaces #20859. >From 6593f517fbfc3b8fef8f61ff0af2e4baed5fafc9 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt <[email protected]> Date: Sat, 8 Nov 2025 00:52:03 +0100 Subject: [PATCH] avutil/timecode: Fix -Wformat-truncation warning Using unsigned for fps more natural since the corresponding AVTimecode field is unsigned and fixes a -Wformat-truncation warning from GCC 16: in case fps were negative, the hours, minutes and seconds would be negative, leading to an additional '-' which is not accounted for in AV_TIMECODE_STR_SIZE. Signed-off-by: Andreas Rheinhardt <[email protected]> --- libavutil/timecode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/timecode.c b/libavutil/timecode.c index bca16b6ac2..b5352a3961 100644 --- a/libavutil/timecode.c +++ b/libavutil/timecode.c @@ -103,7 +103,7 @@ uint32_t av_timecode_get_smpte(AVRational rate, int drop, int hh, int mm, int ss char *av_timecode_make_string(const AVTimecode *tc, char *buf, int framenum_arg) { - int fps = tc->fps; + unsigned fps = tc->fps; int drop = tc->flags & AV_TIMECODE_FLAG_DROPFRAME; int hh, mm, ss, ff, ff_len, neg = 0; int64_t framenum = framenum_arg; -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
