Hi, This short series lays the groundwork for ordered-chapter playback in Matroska, fixing trac ticket #3123.
To start with I added type defs and parsing for editions. I stay compatible with the existing logic by fetching the chapters from all editions thereby flattening the structure. I think It would be a good idea to add an option that only fetches the default or first edition staying compliant to the matroska spec. Maybe adding --edition X and --default-edition in a future patch is appropriate. Next steps would be dealing with external chapter files. This is my first patch let me know if I can improve anything, my C is a little rusty. I manually added the video from the ticket as a fate test just to make sure it was read corectly. make fate-matroska TEST matroska-prores-zlib TEST matroska-prores-header-insertion-bz2 TEST matroska-remux TEST matroska-xiph-lacing TEST matroska-wavpack-missing-codecprivate TEST matroska-zlib-decompression TEST matroska-lzo-decompression TEST matroska-flac-channel-mapping TEST matroska-flac-extradata-update TEST webm-av1-extradata-update TEST matroska-move-cues-to-front TEST matroska-avoid-negative-ts TEST matroska-ms-mode TEST matroska-qt-mode TEST matroska-pgs-remux TEST matroska-pgs-remux-durations TEST matroska-dvbsub-remux TEST matroska-spherical-mono TEST matroska-side-data-pref-codec TEST matroska-side-data-pref-packet TEST matroska-alac-remux TEST webm-dash-chapters TEST matroska-zero-length-block TEST matroska-non-rotation-displaymatrix TEST matroska-crop TEST matroska-dovi-write-config7 TEST matroska-dovi-write-config8 TEST matroska-spherical-mono-remux TEST matroska-mastering-display-metadata TEST matroska-h264-remux TEST matroska-vp8-alpha-remux TEST matroska-mpegts-remux TEST matroska-opus-remux TEST matroska-ogg-opus-remux TEST matroska-encoding-delay TEST matroska-stereo_mode TEST webm-webvtt-remux TEST webm-hdr10-plus-remux TEST matroska-hdr10-plus-remux Kind regards, Alexander Westberg-Bladh Alexander Westberg-Bladh (3): avformat/matroska: Add element IDs for ordered chapters avformat/matroskadec: Add data structures for ordered chapters avformat/matroskadec: Update EBML syntax to parse EditionEntry libavformat/matroska.h | 2 + libavformat/matroskadec.c | 99 ++++++++++++++++++++++++--------------- 2 files changed, 64 insertions(+), 37 deletions(-) -- 2.51.2 _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
