Hi Karl On Sun, Mar 08, 2026 at 06:07:35PM +0100, Karl Mogensen via ffmpeg-devel wrote: > Why: the change is done to comply with lilv expectations of hosts. > > Added call lilv_instance_activate in the config_output function to abide by > lilv documentation that states it must be called before lilv_instance_run: > "This MUST be called before calling lilv_instance_run()" - documentation > source (https://github.com/lv2/lilv/blob/main/include/lilv/lilv.h) > > Added call lilv_instance_deactivate in the uninit function to abide by lv2 > documentation: > "If a host calls activate(), it MUST call deactivate() at some point in the > future" - documentation source > (https://gitlab.com/lv2/lv2/-/blob/main/include/lv2/core/lv2.h) > > Added instance_activated integer to LV2Context struct to track if instance > was activated and only do lilv_instance_deactivate if was activated to abide > by lv2 documentation: > "Hosts MUST NOT call deactivate() unless activate() was previously called." - > documentation source > (https://gitlab.com/lv2/lv2/-/blob/main/include/lv2/core/lv2.h) > > Regarding the patcheck warning (possibly constant :instance_activated): > This is a false positive since the struct member is zero-initialized. > > Fixes: trac issue #11661 (https://trac.ffmpeg.org/ticket/11661) > Reported-by: Dave Flater > Signed-off-by: Karl Mogensen <[email protected]> > > v2: Move lilv_instance_deactivate() to the top of uninit(), before the > lilv_node_free() and uri_table_destroy() calls, as requested by > Michael Niedermayer. This ordering is more logically sound as > deactivate is called before cleaning up metadata. > --- > libavfilter/af_lv2.c | 6 ++++++ > 1 file changed, 6 insertions(+)
will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualities wherein our enemies excel us and endeavor to excel them, by avoiding what is faulty, and imitating what is excellent in them. -- Plutarch
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
