On 12/04/2026 18:41, Michael Niedermayer via ffmpeg-devel wrote:
Hi everyone Last easterbunny brought eggs and in one egg there was a life fairy. She said her name is forgejo fairy and she wants to help the project and community. She is still quite young so please be gentle with her, ATM what she can do is * scan pull requests for ones that are stale. More precissely + No activity for 7 days and + open and + not WIP and + CI passes and + mergable = no conflicts and + no open change requests and + activity since the last fairy reaction or no previous and * she can read the patches, files patched and around 5000 files from FFmpeg git HEAD as well as all past comments in the PR * she will try to review the changes and write a clean and concise comment also considering past comments so as no to add redudant information * if EVERYTHING lines up she will approve the PR this will not on its own trigger any merge. Only if some human developer clicks the merge/rebase button or has previously set the PR to auto merge will that trigger a merge (this affects ATM at maximum 6 PRs) * you can add her to the reviewer of a PR and that will decrease the "No activity" time to 1 day for that PR Initially, i will set the "No activity time" to 56 days so she will only process teh very stalest PRs and then slowly decrease it Also it will be run by hand not by cron job first and manually supervised. (that means i should be able to stop anything outrageous but i certainly will not recognize incorrect reviews) My expectation is that >50% of the reviews will be usefull As she grows she will gain more abilities How to opt out? Get a human review before the 7-56 days Examples: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20005#issuecomment-36271 https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20059#issuecomment-36273 Thx
I think having an automatic review can be helpful, but my suggestion would be to better indicate that it is some kind of auto-generated comment. There could be some kind of "(This message is auto-generated by the review bot. For details see <some link>.)" message footer, and in the linked page there could be some explanation on the conditions when a review comment is generated. Possibly some of that information could also be included in the profile page of the bot?
Further it might be good to decouple the patch auto-acceptance from the review bot. Currently it appears like the bot / LLM is the judge whether a patch can be accepted or not. From what I understand there are fixed rules of inactivity / author rights so that should be better reflected. Possibly just use a separate bot account, with its rules documented somewhere?
Regards, Tobias _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
