Priyanshuthapliyal via ffmpeg-devel (HE12026-04-15): > PR #22828 opened by Priyanshuthapliyal > URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22828 > Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22828.patch > > Add a FATE test for the `bench` filter, which previously had no > coverage. Exercises both `start` and `stop` actions. >  > > > >From 5cb80647314a29f7b286ac6db70d5e7f79ae1f95 Mon Sep 17 00:00:00 2001 > From: Priyanshu Thapliyal <[email protected]> > Date: Wed, 15 Apr 2026 18:33:51 +0530 > Subject: [PATCH] fate/filter: add bench filter coverage test > > --- > tests/fate/filter-video.mak | 3 +++ > tests/ref/fate/filter-bench | 12 ++++++++++++ > 2 files changed, 15 insertions(+) > create mode 100644 tests/ref/fate/filter-bench > > diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak > index 5016ea9d4d..4dd3005112 100644 > --- a/tests/fate/filter-video.mak > +++ b/tests/fate/filter-video.mak > @@ -90,6 +90,9 @@ fate-filter-lavd-testsrc: CMD = framecrc -f lavfi -i > testsrc=r=7:n=2:d=10 > FATE_FILTER-$(call FILTERFRAMECRC, TESTSRC2) += $(addprefix > fate-filter-testsrc2-, yuv420p yuv444p rgb24 rgba) > fate-filter-testsrc2-%: CMD = framecrc -lavfi testsrc2=r=7:d=10 -pix_fmt > $(word 4, $(subst -, ,$(@))) > > +FATE_FILTER-$(call FILTERFRAMECRC, TESTSRC2 BENCH) += fate-filter-bench > +fate-filter-bench: CMD = framecrc -lavfi > "testsrc2=r=7:d=1,bench=action=start,bench=action=stop" > + > FATE_FILTER-$(call FILTERFRAMECRC, ALLRGB) += fate-filter-allrgb > fate-filter-allrgb: CMD = framecrc -lavfi allrgb=rate=5:duration=1 -pix_fmt > rgb24 > > diff --git a/tests/ref/fate/filter-bench b/tests/ref/fate/filter-bench > new file mode 100644 > index 0000000000..b5920b775f > --- /dev/null > +++ b/tests/ref/fate/filter-bench > @@ -0,0 +1,12 @@ > +#tb 0: 1/7 > +#media_type 0: video > +#codec_id 0: rawvideo > +#dimensions 0: 320x240 > +#sar 0: 1/1 > +0, 0, 0, 1, 115200, 0xeba70ff3 > +0, 1, 1, 1, 115200, 0xb986bcbd > +0, 2, 2, 1, 115200, 0x8567f6cf > +0, 3, 3, 1, 115200, 0xed18e21f > +0, 4, 4, 1, 115200, 0x0054f5dd > +0, 5, 5, 1, 115200, 0x6fedfa63 > +0, 6, 6, 1, 115200, 0x3226f459
Hi. Thanks for the patch. I do not think it can count at as a test for the filter: it tests that it did not crash or change the frames, but not that it did its job or anything at all. Testing the filter would require at least checking in the console output is the benchmark has been printed with values that are numerically plausible. Regards, -- Nicolas George _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
