PR #22942 opened by kjg0724
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22942
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22942.patch
dst0/dst1 are uint16_t* allocated as width * sizeof(uint16_t), but
the memcmp at the end of check_add_left_pred_16 only compared `width`
bytes — missing the second half of each buffer. Same pattern used
correctly in tests/checkasm/huffyuvdsp.c (memcmp with width * sizeof()).
While at it, fix missing whitespace around & and || on the same line.
Fixes: bb523a2d3fc3 ("tests/checkasm/llviddsp: Reindent after the previous
commit")
From c7d615ca65e50bf333edc7379b83815a929f4a89 Mon Sep 17 00:00:00 2001
From: Jeongkeun Kim <[email protected]>
Date: Tue, 28 Apr 2026 13:51:25 +0900
Subject: [PATCH] tests/checkasm/llviddsp: fix add_left_pred_int16 buffer
compare size
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
dst0/dst1 are uint16_t* allocated as width * sizeof(uint16_t), but
the memcmp at the end of check_add_left_pred_16 only compared `width`
bytes — missing the second half of each buffer. Same pattern used
correctly in tests/checkasm/huffyuvdsp.c (memcmp with width * sizeof()).
While at it, fix missing whitespace around & and || on the same line.
Fixes: bb523a2d3fc3 ("tests/checkasm/llviddsp: Reindent after the previous
commit")
Signed-off-by: Jeongkeun Kim <[email protected]>
---
tests/checkasm/llviddsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/checkasm/llviddsp.c b/tests/checkasm/llviddsp.c
index a8245b0d94..1094638229 100644
--- a/tests/checkasm/llviddsp.c
+++ b/tests/checkasm/llviddsp.c
@@ -145,7 +145,7 @@ static void check_add_left_pred_16(LLVidDSPContext *c,
unsigned mask, int width,
res0 = call_ref(dst0, src0, mask, width, acc);
res1 = call_new(dst1, src1, mask, width, acc);
- if ((res0 &0xFFFF) != (res1 &0xFFFF)|| memcmp(dst0, dst1, width))
+ if ((res0 & 0xFFFF) != (res1 & 0xFFFF) || memcmp(dst0, dst1, width *
sizeof(*dst0)))
fail();
bench_new(dst1, src1, mask, width, acc);
--
2.52.0
_______________________________________________
ffmpeg-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
