PR #22982 opened by Jun Zhao (mypopydev) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22982 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22982.patch
$(FFMPEG) expands to "ffmpeg.exe" on Windows/MSYS2 and bypasses fate-run.sh's ffmpeg() shell function, falling through to PATH and picking up an externally-installed ffmpeg instead of $target_path's freshly built binary. That stale binary lacked the rejection added in a45fe72c9d, causing msys2-clang64/clangarm64/ucrt64 slots to silently produce 250x2 instead of failing at 500x0. Switch to bare "ffmpeg" so the wrapper resolves the local build correctly on all platforms, matching the convention used by other call sites in tests/fate/*.mak. Signed-off-by: Jun Zhao <[email protected]> >From a9cca9ab6a206160522b17533ed83020366bfd2b Mon Sep 17 00:00:00 2001 From: Jun Zhao <[email protected]> Date: Fri, 1 May 2026 19:20:14 +0800 Subject: [PATCH] fate/filter-video: use ffmpeg wrapper for scale-zero-dim test $(FFMPEG) expands to "ffmpeg.exe" on Windows/MSYS2 and bypasses fate-run.sh's ffmpeg() shell function, falling through to PATH and picking up an externally-installed ffmpeg instead of $target_path's freshly built binary. That stale binary lacked the rejection added in a45fe72c9d, causing msys2-clang64/clangarm64/ucrt64 slots to silently produce 250x2 instead of failing at 500x0. Switch to bare "ffmpeg" so the wrapper resolves the local build correctly on all platforms, matching the convention used by other call sites in tests/fate/*.mak. Signed-off-by: Jun Zhao <[email protected]> --- tests/fate/filter-video.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak index f157496d06..c1f973ece0 100644 --- a/tests/fate/filter-video.mak +++ b/tests/fate/filter-video.mak @@ -528,7 +528,7 @@ fate-filter-scalechroma: CMD = framecrc -flags bitexact -s 352x288 -pix_fmt yuv4 # filter and potentially hanging downstream encoders (issue #22817). # Verify that such invalid dimensions are now rejected explicitly. FATE_FILTER-$(call ALLYES, SCALE_FILTER COLOR_FILTER LAVFI_INDEV WRAPPED_AVFRAME_ENCODER NULL_MUXER) += fate-filter-scale-zero-dim -fate-filter-scale-zero-dim: CMD = ! $(FFMPEG) -nostdin -hide_banner -f lavfi -i "color=c=red:s=3000x2:d=1" -vf "scale=iw/2:-2,scale=iw/3:-2,scale=iw/2:-2" -f null none +fate-filter-scale-zero-dim: CMD = ! ffmpeg -hide_banner -f lavfi -i "color=c=red:s=3000x2:d=1" -vf "scale=iw/2:-2,scale=iw/3:-2,scale=iw/2:-2" -f null none fate-filter-scale-zero-dim: CMP = null FATE_FILTER_VSYNTH_VIDEO_FILTER-$(CONFIG_VFLIP_FILTER) += fate-filter-vflip -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
