Log a warning message when the 'x264opts' is set.
Signed-off-by: Lori-Shu <[email protected]>
---
Hello FFmpeg developers,
I noticed in the Bug Tracker (Cleanup section) that there is a task to prune
one of the two methods for overriding x264 options (x264opts and x264-params).
I am planning to submit a patch to formally deprecate x264opts by adding a
warning log and eventually merging the logic. Before I proceed with a deep
refactor:
Is anyone currently working on this?
Is there any consensus on which one to keep? (I assume x264-params is the
modern choice).
Any guidance would be appreciated.
libavcodec/libx264.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c
index b688d4f321..d303b313fc 100644
--- a/libavcodec/libx264.c
+++ b/libavcodec/libx264.c
@@ -1355,6 +1355,8 @@ static av_cold int X264_init(AVCodecContext *avctx)
x4->params.b_full_recon = 1;
if(x4->x264opts){
+ av_log(avctx, AV_LOG_WARNING,
+ "The 'x264opts' option is deprecated: please use 'x264-params'
instead.\n");
const char *p= x4->x264opts;
while(p){
char param[4096]={0}, val[4096]={0};
--
2.49.0.windows.1
_______________________________________________
ffmpeg-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
