Hi. I am not finding the time or courage to address this properly, especially with the unreadable discussion existing in the web monster. So I will only give short comments to this mail.
岑湛权 (HE12026-03-03): > Resolution: FFmpeg's scheduler performs cycle detection via > DFS during initialization (ffmpeg_sched.c:1435-1508). Cyclic > graphs are rejected outright at runtime, so infinite recursion > cannot occur. As documented in ffmpeg.texi, feedback patterns > must use multiple independent filter graphs, not cycles within > a single graph. libavfilter is supposed to support cyclic paths. If the new fftools code does broke that… insert the “surprised Pikachu” animated gif here. But that is only the fftools code. OTOH, adding a brand new field in all contexts for this features… this feature better be very important. > 2) Nicolas George (you) requested a patch series with real > examples demonstrating the use case. > > Resolution: Commit 2 was added, extending sendcmd/asendcmd > with the mode option and accompanying FATE tests. That is not enough. To begin with, you are adding options, but I am not seeing the string /doc/ in the whole patchset, that is an immediate reject. Not only does the feature need to be documented, it needs to prove its usefulness: it needs an example that shows something made possible by this feature, something that was not previously possible with different means. Regards, -- Nicolas George _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
