PR #23221 opened by crueter
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23221
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23221.patch

There's a funny edge case where compiling in every single codec under
the sun can cause `libavcodec` to fail on Git Bash under Windows,
**because the generated cmdline is over 8192 characters long lmao**

So rather than delegate to a subshell, this changes the object emission
step to use GNU make builtins (which are not confined by shell rules)

Signed-off-by: crueter <[email protected]>


>From aa3aec4b50c46f75c23f368d322963a0aeda76e0 Mon Sep 17 00:00:00 2001
From: crueter <[email protected]>
Date: Mon, 25 May 2026 01:19:29 -0400
Subject: [PATCH] build: Prevent emission of extraordinarily long lines

There's a funny edge case where compiling in every single codec under
the sun can cause `libavcodec` to fail on Git Bash under Windows,
**because the generated cmdline is over 8192 characters long lmao**

So rather than delegate to a subshell, this changes the object emission
step to use GNU make builtins (which are not confined by shell rules)

Signed-off-by: crueter <[email protected]>
---
 ffbuild/library.mak | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ffbuild/library.mak b/ffbuild/library.mak
index 91daa9c25f..b91ecb632a 100644
--- a/ffbuild/library.mak
+++ b/ffbuild/library.mak
@@ -36,7 +36,7 @@ endif
 $(SUBDIR)$(LIBNAME): $(OBJS) $(STLIBOBJS)
        $(RM) $@
 ifeq ($(RESPONSE_FILES),yes)
-       $(Q)echo $^ > [email protected]
+       $(file >[email protected],$(OBJS) $(STLIBOBJS))
        $(AR) $(ARFLAGS) $(AR_O) @[email protected]
 else
        $(AR) $(ARFLAGS) $(AR_O) $^
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to