PR #23282 opened by michaelni
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23282
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23282.patch

Fixes: integer overflow in SAR
Found-by: jiale yao
Signed-off-by: Michael Niedermayer <[email protected]>


>From c92aac7727efbfedfa5b4287e87a05e7b34cbecb Mon Sep 17 00:00:00 2001
From: Michael Niedermayer <[email protected]>
Date: Sat, 30 May 2026 22:05:34 +0200
Subject: [PATCH] avfilter/vf_scale: split rational multiply

Fixes: integer overflow in SAR
Found-by: jiale yao
Signed-off-by: Michael Niedermayer <[email protected]>
---
 libavfilter/vf_scale.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c
index aa506ff53c..8cef2579bc 100644
--- a/libavfilter/vf_scale.c
+++ b/libavfilter/vf_scale.c
@@ -658,7 +658,8 @@ static int config_props(AVFilterLink *outlink)
     if (scale->reset_sar)
         outlink->sample_aspect_ratio = (AVRational){1, 1};
     else if (inlink0->sample_aspect_ratio.num){
-        outlink->sample_aspect_ratio = av_mul_q((AVRational){outlink->h * 
inlink0->w, outlink->w * inlink0->h}, inlink0->sample_aspect_ratio);
+        AVRational q = av_mul_q((AVRational){outlink->h, outlink->w}, 
(AVRational){inlink0->w, inlink0->h});
+        outlink->sample_aspect_ratio = av_mul_q(q, 
inlink0->sample_aspect_ratio);
     } else
         outlink->sample_aspect_ratio = inlink0->sample_aspect_ratio;
 
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to