PR #23437 opened by Niklas Haas (haasn)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23437
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23437.patch

This fails to compile with C23 standard attributes otherwise.

Technically only av_unused requires this, but move the other attributes
as well for consistency / future proofing.

Signed-off-by: Niklas Haas <[email protected]>

# Summary of changes

Briefly describe what this PR does and why.

<!--
If this PR requires new FATE test samples, attach them to the PR and
list their target paths below (relative to the fate-suite root).

Attached filenames must match the sample's filename:

```fate-samples
# e.g. vorbis/new-sample.ogg
```
-->



>From 7b59a86633b81e7777aece99655e94052324597f Mon Sep 17 00:00:00 2001
From: Niklas Haas <[email protected]>
Date: Wed, 10 Jun 2026 16:26:12 +0200
Subject: [PATCH] swscale/uops_tmpl: move attributes before `static` keyword

This fails to compile with C23 standard attributes otherwise.

Technically only av_unused requires this, but move the other attributes
as well for consistency / future proofing.

Signed-off-by: Niklas Haas <[email protected]>
---
 libswscale/uops_tmpl.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libswscale/uops_tmpl.h b/libswscale/uops_tmpl.h
index 80c6e5221d..176846ad14 100644
--- a/libswscale/uops_tmpl.h
+++ b/libswscale/uops_tmpl.h
@@ -85,7 +85,7 @@ typedef struct SwsOpIter {
 
 /* Helper macros to make writing common function signatures less painful */
 #define DECL_FUNC(NAME, ...)                                                   
 \
-    static av_always_inline void                                               
 \
+    av_always_inline static void                                               
 \
         fn(NAME)(SwsOpIter *restrict iter, const SwsOpImpl *restrict impl,     
 \
                  pixel_t *restrict x, pixel_t *restrict y,                     
 \
                  pixel_t *restrict z, pixel_t *restrict w,                     
 \
@@ -112,12 +112,12 @@ typedef struct SwsOpIter {
 
 /* Helper macros for common op setup code */
 #define DECL_SETUP(NAME, PARAMS, OUT)                                          
 \
-    static av_unused int fn(NAME)(const SwsImplParams *PARAMS,                 
 \
+    av_unused static int fn(NAME)(const SwsImplParams *PARAMS,                 
 \
                                   SwsImplResult *OUT)
 
 /* Helper macro for declaring kernel entry points */
 #define DECL_IMPL(FUNC, NAME, TYPE, UOP, ...)                                  
 \
-    static av_flatten void NAME##_c(SwsOpIter *restrict iter,                  
 \
+    av_flatten static void NAME##_c(SwsOpIter *restrict iter,                  
 \
                                     const SwsOpImpl *restrict impl,            
 \
                                     void *restrict x, void *restrict y,        
 \
                                     void *restrict z, void *restrict w)        
 \
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to