PR #23483 opened by mkver
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23483
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23483.patch

The functions do the same, yet the dedicated functions
from hpeldsp are more optimized.
(Notice that the motion estimation code only uses
aligned scratchpad buffers as destination when using
hdsp functions, so one Snow-specific functions like
for the me-cmp API are not necessary.)


>From 68acda904ad4889703505055e57fc1c34b20e8f0 Mon Sep 17 00:00:00 2001
From: Andreas Rheinhardt <[email protected]>
Date: Mon, 15 Jun 2026 07:20:07 +0200
Subject: [PATCH] avcodec/snow: Don't override fpel hdsp function

The functions do the same, yet the dedicated functions
from hpeldsp are more optimized.
(Notice that the motion estimation code only uses
aligned scratchpad buffers as destination when using
hdsp functions, so one Snow-specific functions like
for the me-cmp API are not necessary.)

Signed-off-by: Andreas Rheinhardt <[email protected]>
---
 libavcodec/snow.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libavcodec/snow.c b/libavcodec/snow.c
index 5c13709b5c..38570645b7 100644
--- a/libavcodec/snow.c
+++ b/libavcodec/snow.c
@@ -470,11 +470,9 @@ static void mc_block_hpel ## dx ## dy ## b_w(uint8_t *dst, 
const uint8_t *src, p
     mc_block(NULL, dst, src-(HTAPS_MAX/2-1)-(HTAPS_MAX/2-1)*stride, stride, 
b_w, b_w, dx, dy);\
 }
 
-mca( 0, 0,16)
 mca( 8, 0,16)
 mca( 0, 8,16)
 mca( 8, 8,16)
-mca( 0, 0,8)
 mca( 8, 0,8)
 mca( 0, 8,8)
 mca( 8, 8,8)
@@ -509,7 +507,6 @@ av_cold int ff_snow_common_init(AVCodecContext *avctx){
     s->hdsp.put_no_rnd_pixels_tab[1][dy/4+dx/8]=\
         mc_block_hpel ## dx ## dy ## 8;
 
-    mcfh(0, 0)
     mcfh(8, 0)
     mcfh(0, 8)
     mcfh(8, 8)
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to