On Wed, Sep 3, 2025 at 11:11 AM Kyle Swanson via ffmpeg-devel
<[email protected]> wrote:
>
> Hi,
>
> On Tue, Sep 2, 2025 at 9:41 AM Kyle Swanson <[email protected]> wrote:
> >
> > On Wed, Aug 20, 2025 at 2:09 PM Kyle Swanson <[email protected]> wrote:
> > >
> > > Hi,
> > >
> > > On Wed, Jul 23, 2025 at 10:51 AM Nil Fons Miret via ffmpeg-devel
> > > <[email protected]> wrote:
> > > > Pinging this patch from a couple weeks ago. To be clear, I am not sure
> > > > how people typically use ffmpeg's ID3v2 support, so please let me know
> > > > if the patch is missing something and I'm happy to iterate on it, but
> > > > it does seem to me that trying to parse it from rawvideo inputs is
> > > > wrong.
> > >
> > > Anyone interested in testing this? Please see Nil's repro steps above.
> > > Otherwise, I'll merge this sometime next week.
> >
> > Will push tomorrow, thanks.
>
> Pushed.
>
> Thanks,
> Kyle
Hi,
Sorry for the late reply. From reading the patch, it seems like this
dropped ID3v2 parsing for the wav format and unintentionally applied
it to w64 instead (w64 happens to be at the end of wavdec.c, after the
wav demuxer):
> diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c
> index c65e0a2723..4c47a5f05c 100644
> --- a/libavformat/wavdec.c
> +++ b/libavformat/wavdec.c
> @@ -1011,7 +1011,7 @@ static const AVClass w64_demuxer_class = {
> const FFInputFormat ff_w64_demuxer = {
> .p.name = "w64",
> .p.long_name = NULL_IF_CONFIG_SMALL("Sony Wave64"),
> - .p.flags = AVFMT_GENERIC_INDEX,
> + .p.flags = AVFMT_GENERIC_INDEX | AVFMT_FLAG_ID3V2_AUTO,
This was changed to flags_internal = FF_INFMT_FLAG_ID3V2_AUTO in a
later patch, but the same issue persists (it's applied to w64 rather
than wav).
Probably this ought to be applied to the wav demuxer and removed from
w64 (and maybe backported to 8.1?)
It would also be nice to have a sample of such a file in FATE so
testing could catch this sort of thing.
Thanks,
-- Daniel
_______________________________________________
ffmpeg-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
