PR #24867 opened by michaelni
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/24867
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/24867.patch

The existing dca encoder tests only use a stereo source, so the LFE
history handling in shift_history() was not covered. Add a test
encoding tests/data/asynth-44100-6.wav (5.1), its output differs
without f391d256fd.

Assisted-by: Fairy



>From cc7e9b90e988ec526c84400b3864d71176fe9d94 Mon Sep 17 00:00:00 2001
From: Michael Niedermayer <[email protected]>
Date: Sat, 3 Oct 2026 18:09:57 +0000
Subject: [PATCH] fate/acodec: add a 5.1 DCA encoding test covering the LFE
 path

The existing dca encoder tests only use a stereo source, so the LFE
history handling in shift_history() was not covered. Add a test
encoding tests/data/asynth-44100-6.wav (5.1), its output differs
without f391d256fd.

Assisted-by: Fairy
---
 tests/fate/acodec.mak | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/fate/acodec.mak b/tests/fate/acodec.mak
index 54884371ac..e25624e9ac 100644
--- a/tests/fate/acodec.mak
+++ b/tests/fate/acodec.mak
@@ -114,12 +114,17 @@ FATE_ACODEC-$(call ENCDEC, ALAC, MOV, ARESAMPLE_FILTER) 
+= fate-acodec-alac
 fate-acodec-alac: FMT = mov
 fate-acodec-alac: CODEC = alac -compression_level 1
 
-FATE_ACODEC-$(call ENCDEC, DCA, DTS, ARESAMPLE_FILTER) += fate-acodec-dca
+FATE_ACODEC-$(call ENCDEC, DCA, DTS, ARESAMPLE_FILTER) += fate-acodec-dca 
fate-acodec-dca-lfe
 fate-acodec-dca: tests/data/asynth-44100-2.wav
 fate-acodec-dca: SRC = tests/data/asynth-44100-2.wav
 fate-acodec-dca: CMD = md5 -i $(TARGET_PATH)/$(SRC) -c:a dca -strict -2 -f dts 
-flags +bitexact -af aresample
 fate-acodec-dca: CMP = oneline
 fate-acodec-dca: REF = 2aa580ac67820fce4f581b96ebb34acc
+fate-acodec-dca-lfe: tests/data/asynth-44100-6.wav
+fate-acodec-dca-lfe: SRC = tests/data/asynth-44100-6.wav
+fate-acodec-dca-lfe: CMD = md5 -i $(TARGET_PATH)/$(SRC) -c:a dca -strict -2 -f 
dts -flags +bitexact -af aresample
+fate-acodec-dca-lfe: CMP = oneline
+fate-acodec-dca-lfe: REF = f13388591280aa318277115e0aec9df5
 
 FATE_ACODEC-$(call ENCDEC, DCA, WAV, ARESAMPLE_FILTER PIPE_PROTOCOL) += 
fate-acodec-dca2
 fate-acodec-dca2: CMD = enc_dec_pcm dts wav s16le $(SRC) -c:a dca -strict -2 
-flags +bitexact -af aresample
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to