PR #25072 opened by romainhedouin URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/25072 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/25072.patch
gain_map_max was printed from channel->gain_map_min. Update the FATE reference accordingly. Signed-off-by: romainhedouin <[email protected]> <!-- If this PR requires new FATE test samples, attach them to the PR and list their target paths below (relative to the fate-suite root). Attached filenames must match the sample's filename: ```fate-samples # e.g. vorbis/new-sample.ogg ``` --> >From 687992df81051e28cbd452d9693c9f92f7d1bd59 Mon Sep 17 00:00:00 2001 From: romainhedouin <[email protected]> Date: Wed, 14 Oct 2026 20:22:50 +0200 Subject: [PATCH] fftools/ffprobe: print gain_map_max from the right field gain_map_max was printed from channel->gain_map_min. Update the FATE reference accordingly. Signed-off-by: romainhedouin <[email protected]> --- fftools/ffprobe.c | 2 +- tests/ref/fate/mov-heic-demux-still-image-gainmap-tmap | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 664a4802ef..42a255ebe7 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -1275,7 +1275,7 @@ static void print_pkt_side_data(AVTextFormatContext *tfc, const struct AVGainMapChannel *channel = &gain->channels[c]; avtext_print_section_header(tfc, "Gain Map Channel", section_component[container]); print_q("gain_map_min", channel->gain_map_min, '/'); - print_q("gain_map_max", channel->gain_map_min, '/'); + print_q("gain_map_max", channel->gain_map_max, '/'); print_q("gamma", channel->gamma, '/'); print_q("base_offset", channel->base_offset, '/'); print_q("alternate_offset", channel->alternate_offset, '/'); diff --git a/tests/ref/fate/mov-heic-demux-still-image-gainmap-tmap b/tests/ref/fate/mov-heic-demux-still-image-gainmap-tmap index 4f748404fe..461878c0d8 100644 --- a/tests/ref/fate/mov-heic-demux-still-image-gainmap-tmap +++ b/tests/ref/fate/mov-heic-demux-still-image-gainmap-tmap @@ -40,4 +40,4 @@ stream|index=2|id=0x3|disposition:default=0|disposition:dub=0|disposition:origin stream|index=3|id=0x4|disposition:default=0|disposition:dub=0|disposition:original=0|disposition:comment=0|disposition:lyrics=0|disposition:karaoke=0|disposition:forced=0|disposition:hearing_impaired=0|disposition:visual_impaired=0|disposition:clean_effects=0|disposition:attached_pic=0|disposition:timed_thumbnails=0|disposition:non_diegetic=0|disposition:captions=0|disposition:descriptions=0|disposition:metadata=0|disposition:dependent=1|disposition:still_image=0|disposition:multilayer=0|side_datum/icc_profile:side_data_type=ICC Profile stream_group|index=1|id=0x7|nb_streams=2|type=Gain Map (Split base rendition and gain map)|component_entry/gain_map__split_base_rendition_and_gain_map_:el_index=1|component_entry/gain_map__split_base_rendition_and_gain_map_:width=600|component_entry/gain_map__split_base_rendition_and_gain_map_:height=800|disposition:default=0|disposition:dub=0|disposition:original=0|disposition:comment=0|disposition:lyrics=0|disposition:karaoke=0|disposition:forced=0|disposition:hearing_impaired=0|disposition:visual_impaired=0|disposition:clean_effects=0|disposition:attached_pic=0|disposition:timed_thumbnails=0|disposition:non_diegetic=0|disposition:captions=0|disposition:descriptions=0|disposition:metadata=0|disposition:dependent=0|disposition:still_image=0|disposition:multilayer=0|side_datum/icc_profile:side_data_type=ICC Profile stream_group|index=0|id=0x5|nb_streams=4|type=Tile Grid -stream|index=4|id=0x6|disposition:default=0|disposition:dub=0|disposition:original=0|disposition:comment=0|disposition:lyrics=0|disposition:karaoke=0|disposition:forced=0|disposition:hearing_impaired=0|disposition:visual_impaired=0|disposition:clean_effects=0|disposition:attached_pic=0|disposition:timed_thumbnails=0|disposition:non_diegetic=0|disposition:captions=0|disposition:descriptions=0|disposition:metadata=0|disposition:dependent=1|disposition:still_image=0|disposition:multilayer=0|side_datum/gain_map_parameters:side_data_type=Gain Map Parameters|side_datum/gain_map_parameters:version=0|side_datum/gain_map_parameters:use_base_color_space=1|side_datum/gain_map_parameters:base_hdr_headroom=0/1|side_datum/gain_map_parameters:alternate_hdr_headroom=9646899/4194304|side_datum/gain_map_parameters:nb_channels=1|component_entry/gain_map_channel:gain_map_min=0/1|component_entry/gain_map_channel:gain_map_max=0/1|component_entry/gain_map_channel:gamma=1/1|component_entry/gain_map_channel :base_offset=0/1|component_entry/gain_map_channel:alternate_offset=0/1 +stream|index=4|id=0x6|disposition:default=0|disposition:dub=0|disposition:original=0|disposition:comment=0|disposition:lyrics=0|disposition:karaoke=0|disposition:forced=0|disposition:hearing_impaired=0|disposition:visual_impaired=0|disposition:clean_effects=0|disposition:attached_pic=0|disposition:timed_thumbnails=0|disposition:non_diegetic=0|disposition:captions=0|disposition:descriptions=0|disposition:metadata=0|disposition:dependent=1|disposition:still_image=0|disposition:multilayer=0|side_datum/gain_map_parameters:side_data_type=Gain Map Parameters|side_datum/gain_map_parameters:version=0|side_datum/gain_map_parameters:use_base_color_space=1|side_datum/gain_map_parameters:base_hdr_headroom=0/1|side_datum/gain_map_parameters:alternate_hdr_headroom=9646899/4194304|side_datum/gain_map_parameters:nb_channels=1|component_entry/gain_map_channel:gain_map_min=0/1|component_entry/gain_map_channel:gain_map_max=9646899/4194304|component_entry/gain_map_channel:gamma=1/1|component_entry/gain _map_channel:base_offset=0/1|component_entry/gain_map_channel:alternate_offset=0/1 -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
