In buf_realloc, os->bufsize is unsigned int and the code doubles it: nb = av_realloc(os->buf, 2*os->bufsize + AV_INPUT_BUFFER_PADDING_SIZE);
When os->bufsize exceeds UINT_MAX/2, the multiplication overflows to a small value, av_realloc returns a tiny buffer, and the subsequent page write in ogg_read_page goes out of bounds. Reject the reallocation before the overflow can occur. Signed-off-by: age5000 <[email protected]> --- libavformat/oggdec.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/oggdec.c b/libavformat/oggdec.c --- a/libavformat/oggdec.c +++ b/libavformat/oggdec.c @@ -304,7 +304,10 @@ { /* Even if invalid guarantee there's enough memory to read the page */ if (os->bufsize - os->bufpos < size) { - uint8_t *nb = av_realloc(os->buf, 2*os->bufsize + AV_INPUT_BUFFER_PADDING_SIZE); + uint8_t *nb; + if (os->bufsize > UINT_MAX / 2) + return AVERROR(ENOMEM); + nb = av_realloc(os->buf, 2*os->bufsize + AV_INPUT_BUFFER_PADDING_SIZE); if (!nb) return AVERROR(ENOMEM); os->buf = nb; _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
