On Tue, Jan 12, 2016 at 02:39:35PM +0100, Carl Eugen Hoyos wrote: > On Tuesday 12 January 2016 02:31:48 pm Michael Niedermayer wrote: > > > > > + level_id = atoi(x4->level); > > > > > > > > this should check that teres no "tail" after the integer > > > > > > For which command line will this make a difference? > > > I didn't find one... > > > > didnt try but i was thinking of something like 11.8 > > ffmpeg -f lavfi -i testsrc=s=hd1080 -pix_fmt yuv420p -t 1 > -level 11.8 -preset veryslow out.mov > ffmpeg version N-77804-gd64d6ed Copyright (c) 2000-2016 the FFmpeg developers > built with gcc 4.7 (SUSE Linux) > configuration: --enable-gpl --enable-libx264 > libavutil 55. 13.100 / 55. 13.100 > libavcodec 57. 22.100 / 57. 22.100 > libavformat 57. 21.101 / 57. 21.101 > libavdevice 57. 0.100 / 57. 0.100 > libavfilter 6. 23.100 / 6. 23.100 > libswscale 4. 0.100 / 4. 0.100 > libswresample 2. 0.101 / 2. 0.101 > libpostproc 54. 0.100 / 54. 0.100 > Input #0, lavfi, from 'testsrc=s=hd1080': > Duration: N/A, start: 0.000000, bitrate: N/A > Stream #0:0: Video: rawvideo (RGB[24] / 0x18424752), rgb24, 1920x1080 > [SAR > 1:1 DAR 16:9], 25 tbr, 25 tbn, 25 tbc > [libx264 @ 0x29335c0] Error parsing option 'level' with value '11.8'. > Output #0, mov, to 'out.mov': > Stream #0:0: Video: h264, none, q=2-31, 128 kb/s, SAR 1:1 DAR 0:0, 25 fps > Metadata: > encoder : Lavc57.22.100 libx264 > Stream mapping: > Stream #0:0 -> #0:0 (rawvideo (native) -> h264 (libx264)) > Error while opening encoder for output stream #0:0 - maybe incorrect > parameters such as bit_rate, rate, width or height
indeed, i guess x264 checks this internally before our code gets a chance to fail [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Awnsering whenever a program halts or runs forever is On a turing machine, in general impossible (turings halting problem). On any real computer, always possible as a real computer has a finite number of states N, and will either halt in less than N cycles or never halt.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel