Hi, 2016-02-14 6:49 GMT+01:00 Timothy Gu <timothyg...@gmail.com>: > %if HAVE_MMX_INLINE
Isn't that macro meant for C code (and in config.asm without much of a purpose)? I suspect it is not useful, but I haven't dug into that. > +; XXX some of these macros are not used right now, but they will in the > future > +; when more functions are ported. I would still recommend only porting the ones needed in this commit, but I'm not going to bother you further with this. > ; Compute the rounder 32-r or 8-r and unpacks it to m7 > %macro LOAD_ROUNDER_MMX 1 ; round > - movd m7, %1 > + movh m7, %1 Same here: until there's a SSE2 version for some of those functions, which will require specific code (like a shufps), that's unrelated. > +cglobal vc1_%2_hor_16b_shift2, 4, 5, 0, dst, stride, src, rnd, h Do you intend to port more? Because in that case, having a SSE2 version of this one would be possible. And the wider version would be straightforward in SSE2. And that would allow you to put at last a (c) in this code you've spent so much time with. Otherwise looks OK, but I haven't tested. -- Christophe _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
