On Sun, Feb 28, 2016 at 06:11:27AM +0100, Mats Peterson wrote: > On 02/28/2016 05:38 AM, Mats Peterson wrote: > >On 02/28/2016 05:27 AM, Mats Peterson wrote: > >>Use "palette side data" instead of "palette extradata" in error message. > >> > >> > >> > >>_______________________________________________ > >>ffmpeg-devel mailing list > >>ffmpeg-devel@ffmpeg.org > >>http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >> > > > > > >Michael, I would like to add that ff_reshuffle_raw_rgb() that you wrote > >has the benefit of taking care of the correct stride when using stream > >copy as well. Thus, it won't be an "identical" stream copy, but it will > >be a valid one for the output file format in question. > > > >Mats > > > > And Reimar, the AVI muxer libavformat/avienc.c uses *lots* of avio_seek() > all over the place, so it won't work well on stdout regardless of my patch. > I have checked for avio_seek() returning >= 0 in my part of the code in any > case, but it won't make much of a difference.
I think the effect of a failed avio_seek is kind of undefined, so checking the result is not really right as by then it's already broken. I also disagree with your analysis, all other avio_seek I could find are under if (pb->seekable), even if it is sometimes quite non-obvious. Also it might be helpful for you to have a look at tests/fate/demux.mak and tests/fate/video.mak and use copy-paste to write some basic tests for all the things you implement, so it doesn't get broken the moment you look the other way... _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel