On Tue, Mar 8, 2016 at 10:54 PM, Marton Balint <c...@passwd.hu> wrote: > > On Tue, 8 Mar 2016, wm4 wrote: > >> On Tue, 8 Mar 2016 21:29:52 +0100 >> Marton Balint <c...@passwd.hu> wrote: >> >>> Signed-off-by: Marton Balint <c...@passwd.hu> >>> --- >>> libavformat/utils.c | 10 ++++-- >>> tests/ref/fate/gapless2-ipod-aac1 | 72 >>> +++++++++++++++++++-------------------- >>> tests/ref/fate/gapless2-ipod-aac2 | 72 >>> +++++++++++++++++++-------------------- >>> 3 files changed, 80 insertions(+), 74 deletions(-) >>> > >> I'm a probably bit late here, but what's the rationale of increasing the >> start time? >> > > According to docs, start time is supposed to be the pts of the first > decoded frame, therefore skipped samples must be taken into account, when > the start time is determined based on the first packet pts. >
But the skipping is performed by avcodec, not avformat, isn't it? start_time should be the PTS of the first avpacket coming out of avformat, never mind what a decoder might do to that later. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
