On Mon, Jul 18, 2016 at 03:27:12PM +0000, Petru Rares Sincraian wrote: > Hi, > > > Here is the rest of the test. I changed the tabs to spaces, sorry for this.
it seems this doesnt build make distclean ; ./configure && make -j12 fate tests/api/api-seek-test.c: In function ‘main’: tests/api/api-seek-test.c:246:36: warning: ‘j’ may be used uninitialized in this function [-Wuninitialized] tests/api/api-seek-test.c:183:12: note: ‘j’ was declared here tests/api/api-seek-test.c:246:36: warning: ‘i’ may be used uninitialized in this function [-Wuninitialized] tests/api/api-seek-test.c:183:9: note: ‘i’ was declared here ... libavcodec/tests/fft.c:656:6: warning: "AVFFT" is not defined [-Wundef] libavcodec/tests/fft.c:659:13: error: ‘r’ undeclared (first use in this function) libavcodec/tests/fft.c:659:13: note: each undeclared identifier is reported only once for each function it appears in libavcodec/tests/fft.c:660:13: error: ‘d’ undeclared (first use in this function) > > > > Thanks, > > Petru Rares. > > ________________________________ > From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> on behalf of Michael > Niedermayer <mich...@niedermayer.cc> > Sent: Saturday, July 16, 2016 3:22:24 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] fate: add test for avfft > > On Fri, Jul 15, 2016 at 02:07:08PM +0000, Petru Rares Sincraian wrote: > > Hi there, > > > > Here is a patch that changes the avfft test. This test is similar to > > libavcodec/tests/fft-fixed.c. I modified libavcodec/tests/fft.c a bit to > > adapt to make use of the new abi. At the moment I only did test for fft and > > mdct, If no more suggestions then I'll do tests for the remaining modules. > > its a bit difficult to test with just fft and mdct but the code overall > looks good to me > > there are also a few stray tabs in there, they should be replaced by > spaces as tabs cannot be pushed to git master > > thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are best at talking, realize last or never when they are wrong.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
