On Thu, Aug 25, 2016 at 12:31:19PM -0700, Sasi Inguva wrote: > oops. thanks for pointing that out. Even in our version of ffmpeg, that > assert doesn't get compiled so we never catched it. That assert logic is > not correct anymore. At the end of one edit list there can be frames marked > as discard, for which we would keep increasing the timestamp even if they > are marked as discard, so that when the timestamps are rerodered to compute > PTS B-frames get the correct PTS. But the next edit list should always > start with the timestamp of the last-non-discarded frame of the previous > edit list. Hence we will get non-increasing timestamps added as index > entries. > > The test may have passed for you before, because before that line was > assert(..) instead of av_assert1(...) so maybe that line wasn't getting > compiled before. Attaching the 4 patches again.
(i think 3rd one) breaks ./ffmpeg -i ~/tickets/5528/fire.mp3 test.wav ... [mp3 @ 0x393b980] invalid new backstep -1 Assertion avctx->internal->skip_samples >= 0 failed at libavcodec/utils.c:2357 Aborted http://trac.ffmpeg.org/attachment/ticket/5528/fire.mp3 [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is dangerous to be right in matters on which the established authorities are wrong. -- Voltaire
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel