> On Oct 6, 2016, at 4:33 PM, James Almer <jamr...@gmail.com> wrote: > > On 10/6/2016 3:28 PM, Michael Niedermayer wrote: >> On Thu, Oct 06, 2016 at 11:27:08AM -0300, James Almer wrote: >>> On 10/6/2016 7:29 AM, Michael Niedermayer wrote: >>>> On Mon, Oct 03, 2016 at 08:36:56PM -0300, James Almer wrote: >>>>> This patchsets implements the feature requested on ticket #4347. >>>>> The first three patches are preparation work. The first one isn't >>>>> strictly related to the implementation, but comes in handy >>>>> nonetheless. >>>>> >>>>> Patches 4 to 11 can be squashed into a single commit before pushing >>>>> if that's prefered, but for review purposes i split things as one >>>>> patch per Level 1 element being adapted to write a CRC32 element. >>>>> >>>>> Fate tests are updated as needed. >>>> >>>> some questions >>>> Does this reduce writing speed ? for example when remuxing high >>>> bitrate data like rawvideo ? >>> >>> The bulk of the CRC calculation is done once per level 1 element, so it >>> shouldn't affect remuxing speed in a considerable way. But if preferred, >>> i could see about adding an option to disable it. >> >> i guess such a option cant hurt > > Will add it.
Worth adding to the Changelog as well. >> thanks >> >> no furter comments from me about this patchset > > Pushed without squashing, so if problems arise bisect can more accurately > point where things went wrong. > > Thanks. > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel