On 11/14/16, James Almer <jamr...@gmail.com> wrote: > On 11/14/2016 8:01 AM, Michael Niedermayer wrote: >> On Sun, Nov 13, 2016 at 10:32:13PM +0100, Hendrik Leppkes wrote: >>> ffmpeg | branch: master | Hendrik Leppkes <h.lepp...@gmail.com> | Sun Nov >>> 13 22:29:04 2016 +0100| [bd0db4a32d85d027da4d4dc00490c20048090312] | >>> committer: Hendrik Leppkes >>> >>> Merge commit '7a745f014f528d1001394ae4d2f4ed1a20bf7fa2' >>> >>> * commit '7a745f014f528d1001394ae4d2f4ed1a20bf7fa2': >>> options_table: Add aliases for color properties >>> >>> Merged-by: Hendrik Leppkes <h.lepp...@gmail.com> >>> >>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=bd0db4a32d85d027da4d4dc00490c20048090312 >>> --- >>> >>> libavcodec/options_table.h | 32 ++++++++++++++++++++++++-------- >>> libavcodec/version.h | 2 +- >>> 2 files changed, 25 insertions(+), 9 deletions(-) >> >> Please dont forget to add documentation for every option you add. > > Done. > >> IIRC Libav has code to automatically generate documentation from >> AVOptions. Several FFmpeg developers objected against enabling that >> code. IIRC because hand written documentation is of much higher quality > > Automatically generated documentation for options like this sounds very > useful. I don't know why it was rejected. There's not much more "quality" > to be had over manually written lines for AVOptions.
+1 from me, plus help avoid a bit of duplication. My only concern is that AVOptions today feel like "one liner" documentation, maybe some option could be added there for more verbose descriptions within the AVOptions or some odd... :) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
