On 11/17/2016 5:11 PM, Carl Eugen Hoyos wrote: > 2016-11-16 15:02 GMT+01:00 Michael Niedermayer <mich...@niedermayer.cc>: >> On Wed, Nov 16, 2016 at 12:15:28PM +0100, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch improves output for some ffv1 files imo. >>> Current slowdown for the existing decode-line timer is >>> 2%, I wonder if this can be improved through refactoring. >>> >>> Please comment, Carl Eugen >> >>> ffv1dec.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> ab0f3ff58a18145efd66d627ecbf54c35b5c23e6 >>> 0001-lavc-ffv1dec-Scale-output-for-lsb-packed-compression.patch >>> From e4e8277d4f0daeb9f61c2da9ebb167a084b1b93c Mon Sep 17 00:00:00 2001 >>> From: Carl Eugen Hoyos <ceho...@ag.or.at> >>> Date: Wed, 16 Nov 2016 12:03:17 +0100 >>> Subject: [PATCH] lavc/ffv1dec: Scale output for msb-packed compression to >>> full 16bit. >>> >>> 2% slowdown for existing decode-line timer. >>> --- >>> libavcodec/ffv1dec.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> probably ok >> >> also try if using a temporary variable is faster > > Unfortunately not. > > Patch applied, Carl Eugen
You pushed it /before/ addressing people's objections and concerns. A patch that changes the output of a decoder for a codec in the middle of being standardized shouldn't be applied just like that. Especially when it's a controversial change objected by several developers. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel