On Wed, Nov 23, 2016 at 04:54:51PM -0800, Wan-Teh Chang wrote: > On Wed, Nov 23, 2016 at 4:08 PM, Michael Niedermayer > <mich...@niedermayer.cc> wrote: > > > > please read > > http://ffmpeg.org/developer.html > > > > for example it says: > > "Do not commit unrelated changes together." > > > > you combined commits which were split before > > Those changes are closely related. But I will merge those six commits > one at a time.
please do > > > "Testing must be adequate but not excessive. > > If it works for you, others, and passes FATE then it should be OK to > > commit it, provided it fits the other committing criteria. You should not > > worry about over-testing things. If your code has problems (portability, > > triggers compiler bugs, unusual environment etc) they will be reported and > > eventually fixed. " > > > > this fails fate > > Sorry about that! I did run "make fate", but I must have forgotten to > check the test results. > > I assume I should use the standard FFmpeg license header in the new .h files? yes Thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No snowflake in an avalanche ever feels responsible. -- Voltaire
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
