On 1/7/17, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Fri, Jan 06, 2017 at 08:47:39PM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >> --- >> libavformat/electronicarts.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavformat/electronicarts.c b/libavformat/electronicarts.c >> index 30eb723bd5..03422e5b2c 100644 >> --- a/libavformat/electronicarts.c >> +++ b/libavformat/electronicarts.c >> @@ -556,6 +556,7 @@ static int ea_read_header(AVFormatContext *s) >> st->codecpar->codec_tag = 0; /* no tag */ >> st->codecpar->channels = ea->num_channels; >> st->codecpar->sample_rate = ea->sample_rate; >> + FF_RETURN_ON_OVERFLOW(s, ea->bytes > INT_MAX / 8 / 2) > > I think we should ask for a sample when the number of bytes per > sample is larger than 2 or 4 or whatever max we think occurs.
No we should not as such samples are invalid. > > the patch is probably fine > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > I am the wisest man alive, for I know one thing, and that is that I know > nothing. -- Socrates > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel