On Sun, Jan 22, 2017 at 01:33:19PM +0100, Peter Große wrote:
> On Sat, 21 Jan 2017 22:53:56 +0100
> Moritz Barsnick <barsn...@gmx.net> wrote:
>
> > When adding new code, please stick to "if (" with a space. (Also in
> > some of your other patches.)
> >...
> > Two different ways of doing the same thing. ;-) (Assignment to ret
> > embedded in the "if"-clause versus before it.)
>
> Thanks for pointing that out.
>
> The mess with "ret" exists already in the old code, so I'm not sure, whether
> I should fix it only in lines I touch or at all occurances.
> > Another question: the patcheck tool "complains" about "non doxy comments". > What is the correct way of annotating segments of code? Or is it not > recommend at all? Public and private interface should be documented in the header with doxy compatible comments static functions are often not documented, but more documentation certainly is a good thing unless its totally obvious what a function does and everything surrounding sections in funtions are generally documented with normal comments (thats how its done in the codebase not neccessarily the best or only choice) but you may want to consider spliting a function into multiple if it has sections that need documentation [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you think the mosad wants you dead since a long time then you are either wrong or dead since a long time.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
