On Tue, Mar 07, 2017 at 09:59:42AM +0100, Carl Eugen Hoyos wrote: > 2017-02-26 12:04 GMT+01:00 Carl Eugen Hoyos <ceffm...@gmail.com>: > > 2017-02-26 11:51 GMT+01:00 Nicolas George <geo...@nsup.org>: > > >>> -uint8_t* av_packet_get_side_data(AVPacket *pkt, enum > >>> AVPacketSideDataType type, > >> > >>> +uint8_t* av_packet_get_side_data( > >>> +#if FF_API_CONST_GET_SIDE_DATA > >>> +const > >>> +#endif > >>> + AVPacket *pkt, enum > >>> AVPacketSideDataType type, > >> > >> I do not think we need the FF_API dance, since it is not an ABI break. > > > > I agree that there is no ABI break (but I suspect FF_API does not > > imply an ABI break). > > > >> I think is is not an API break either. > > > > I may misremember but I thought it's an API break for c++ users. > > > > Anyway, new patch attached. > > Ping. > Should this not be changed, should one of the patches be applied?
i agree one should be applied, iam not 100% sure if it can break a user app and need the #if or not [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No human being will ever know the Truth, for even if they happen to say it by chance, they would not even known they had done so. -- Xenophanes
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
